[dashing] Remove unused headers MessageTypeSupport.hpp and ServiceTypeSupport.hpp (#481)#484
Merged
jacobperron merged 1 commit intodashingfrom Nov 17, 2020
Merged
Conversation
…pp (#481) Besides the headers not being used, they actually would produce a compilation error if included since the TypeSupport class is not a template class. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
clalancette
reviewed
Nov 10, 2020
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I'm fine with the change, but this code is old enough now that we should probably do a CI run to ensure that things are good with this removed.
Member
Author
Edit: unrelated cppcheck failure. |
clalancette
approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #481 to Dashing.