Remove unexpected template name being passed to TypeSupport class#480
Closed
jacobperron wants to merge 1 commit intomasterfrom
Closed
Remove unexpected template name being passed to TypeSupport class#480jacobperron wants to merge 1 commit intomasterfrom
jacobperron wants to merge 1 commit intomasterfrom
Conversation
The TypeSupport class is not a template class. To be honest, I'm not sure how the code was compiling before this change as I would have expected there to be an error "expected template-name before ‘<’ token". I noticed this suddenly appearing during the ABI check for Foxy, for example: http://build.ros2.org/job/Fpr__rmw_fastrtps__ubuntu_focal_amd64/75/API_5fABI_20report/ Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Superseded by #481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeSupport class is not a template class.
To be honest, I'm not sure how the code was compiling before this change as I would have expected there to be an error "expected template-name before ‘<’ token".
I noticed this suddenly appearing during the ABI check for Foxy, for example:
http://build.ros2.org/job/Fpr__rmw_fastrtps__ubuntu_focal_amd64/75/API_5fABI_20report/