[backport foxy] Fix trying to get topic data that was already removed#421
Merged
dirk-thomas merged 2 commits intofoxyfrom Aug 6, 2020
Merged
[backport foxy] Fix trying to get topic data that was already removed#421dirk-thomas merged 2 commits intofoxyfrom
dirk-thomas merged 2 commits intofoxyfrom
Conversation
* Fix trying to get topic data that was already removed. Signed-off-by: Chen.Lihui <lihui.chen@sony.com> * Revert "Fix trying to get topic data that was already removed." This reverts commit 08632e8. Signed-off-by: Chen.Lihui <lihui.chen@sony.com> * Updated based on suggestions Signed-off-by: Chen.Lihui <lihui.chen@sony.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
470d54f to
3380e50
Compare
jacobperron
reviewed
Aug 6, 2020
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_subscriber_info.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
jacobperron
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #417.