Feature/timestamp 1.9.x#363
Closed
iluetkeb wants to merge 16 commits intoros2:masterfrom
boschresearch:feature/timestamp_1.9.x
Closed
Feature/timestamp 1.9.x#363iluetkeb wants to merge 16 commits intoros2:masterfrom boschresearch:feature/timestamp_1.9.x
iluetkeb wants to merge 16 commits intoros2:masterfrom
boschresearch:feature/timestamp_1.9.x
Conversation
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
… Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
…rmw_fastrtps into feature/timestamp
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
… Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
…rmw_fastrtps into feature/timestamp
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Closed
This was referenced Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #359 that works with the API available in Fast-RTPS 1.9.x only.
It differs slightly from #359, in that it uses source timestamps for services and clients, because receiptionTimestamps for these objects are not directly available in the SampleInfo_t from Fast-RTPS 1.9.x If this is considered a problem, we might just call "system_time_now" for these as well, as is currently already done for subscriptions (where obtaining the SampleInfo is not possible without changing take semantics, based on the 1.9.x API).