Fast-CDR external dependency Quality Declaration#360
Closed
Fast-CDR external dependency Quality Declaration#360
Conversation
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
brawner
suggested changes
Apr 28, 2020
Contributor
brawner
left a comment
There was a problem hiding this comment.
It looks like a lot of my comments from the FastRTPS PR can also be applied here. Could you update this with the most current style and carry over any relevant changes from the other PR and then I'll take a deeper dive?
ahcorde
requested changes
Apr 28, 2020
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
ahcorde
approved these changes
May 1, 2020
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
LGTM, just a small change
brawner
reviewed
May 1, 2020
|
|
||
| As stated in their public repository, *eProsima FastCDR is a C++ library that provides two serialization mechanisms. One is the standard CDR serialization mechanism, while the other is a faster implementation that modifies the standard*. | ||
|
|
||
| ## Summary |
Contributor
There was a problem hiding this comment.
For large paragraphs like these below, it might be better to have once sentence per-line so that the diff is easier to read.
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
brawner
approved these changes
May 1, 2020
Contributor
brawner
left a comment
There was a problem hiding this comment.
Minor nits, but otherwise looks good to me.
Contributor
|
add the QD to the README.md |
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
|
Due to Fast DDS reaching QL1 (eProsima/Fast-DDS#1610), I think this PR can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quality declaration for eProsima Fast-CDR external dependency for ROS2 packages as described in the proposed REP-2004.
This declaration represents some thoughts regarding the current state of this external dependency and how this affect Quality Level 1 for ROS2 packages, feedback is well received.
Signed-off-by: Jorge Perez jjperez@ekumenlabs.com