[dashing] [backport] Type support fixes #342 & #350 #353
Merged
nuclearsandwich merged 2 commits intodashingfrom Mar 13, 2020
Merged
[dashing] [backport] Type support fixes #342 & #350 #353nuclearsandwich merged 2 commits intodashingfrom
nuclearsandwich merged 2 commits intodashingfrom
Conversation
* Add rmw implementation specific pointer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes on rmw_serialize Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes for publishers Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes for subscriptions Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes for services and clients. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Solving linters Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
* Making TypeSupport interface methods const. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Created TypeSupport proxy class Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes on rmw_publisher Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes on rmw_subscription. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes on rmw_client Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Changes on rmw_service Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * linters Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Moving LockedObject template to its own header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * class TypeSupportProxy on its own source file. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Added TypeSupportRegistry Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Added generic pointer to ros type support so we can reference the registry key. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Creator functions passed to type_support_registry. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Added base class for all rmw_fastrtps_dynamic_cpp type support classes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * using TypeSupportRegistry on services and messages Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * using TypeSupportRegistry on rmw_serialize Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Removed unused functions from type_support_common Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Fixing assert code. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Removing unused argument. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Cleanup instead of asserting on destructor. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Improving singleton behavior Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Member
|
nuclearsandwich
approved these changes
Mar 12, 2020
Member
nuclearsandwich
left a comment
There was a problem hiding this comment.
LGTM. Since we no longer have a supported macOS platform for Dashing we needn't wait on macOS CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests backports #342 and #350 back to Dashing.