Add support for Certificate Revocation List files.#52
Conversation
|
From the secure DDS spec:
Is there a consensus among the DDS vendors on how the CRL list is to be encoded, or how enabling it's configuration as implemented? |
For the encoding, both open-source implementations (CycloneDDS and Fast-DDS) rely on OpenSSL (and more specifically, X509_STORE_add_crl) to make CRLs work. That means that they both expect the CRL to be of the form: (it is unclear whether or how Connext implements CRLs; maybe @asorbini can comment?) As far as how to enable CRLs, that is done differently per DDS implementation:
|
At least Fast-RTPS and CycloneDDS support Certificate Revocation Lists, so add it as one of the possible files in the enclave. Note that it is an optional file; if an enclave doesn't have it, then the key will be missing from the returned map. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
3c374f2 to
6d7df2b
Compare
|
CI is green, and this has been approved. I'm going to go ahead and merge this now; if there are any further questions about how this fits into an enclave, we can do follow-ups to make changes. |
@clalancette apologies for the late reply. Connext has supported CRLs for several versions, although I'm not sure about 5.3.1. I also don't recall the exact CRL format, but I suspect it is the same as other implementation, since our default security plugins also rely on OpenSSL. The documentation for the You can find some more information about CRL support here I'll look for an authoritative answer on the exact version and format and get back to you. |
Perfect, thanks @asorbini ! |
At least Fast-RTPS and CycloneDDS support Certificate
Revocation Lists, so add it as one of the possible files
in the enclave. Note that it is an optional file; if
an enclave doesn't have it, then the key will be missing
from the returned map.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Besides the maintainers of this package, also pinging @ruffsl , @mikaelarguedas , and @SidFaber . The addition of this file is essentially expanding the on-disk "API" of an SROS2 security enclave to include the
crl.pemfile, so I'd appreciate any feedback that you may have.