make rmw_dds_common use rosidl_generator_interfaces normally#12
Merged
dirk-thomas merged 5 commits intomasterfrom Apr 10, 2020
Merged
make rmw_dds_common use rosidl_generator_interfaces normally#12dirk-thomas merged 5 commits intomasterfrom
dirk-thomas merged 5 commits intomasterfrom
Conversation
ivanpauno
approved these changes
Apr 9, 2020
Member
Author
|
The last commit swaps the target names to make sure that the interface target has the name of the package. The library uses |
ivanpauno
approved these changes
Apr 10, 2020
Member
SGTM, I guess that was affecting |
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
7afc7ce to
cfc1b8a
Compare
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
ivanpauno
approved these changes
Apr 10, 2020
ivanpauno
reviewed
Apr 10, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.