Skip to content

Update includes after rcutils/get_env.h deprecation#55

Merged
clalancette merged 1 commit intoros2:masterfrom
christophebedard:deprecate-rcutils-get-env-header
May 4, 2021
Merged

Update includes after rcutils/get_env.h deprecation#55
clalancette merged 1 commit intoros2:masterfrom
christophebedard:deprecate-rcutils-get-env-header

Conversation

@christophebedard
Copy link
Copy Markdown
Member

ros2/rcutils#340 deprecates rcutils/get_env.h. This PR doesn't need to wait until the rcutils PR is merged, though.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@christophebedard
Copy link
Copy Markdown
Member Author

CI from ros2/rcutils#340 (comment), building & testing everything:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@asorbini asorbini added the humble PR scheduled for the H-turtle label May 3, 2021
@clalancette
Copy link
Copy Markdown
Contributor

@asorbini FYI, I'm going to go ahead and merge this one so I can also merge ros2/rcutils#340 . Feel free to keep commenting or let me know if you have any objections.

@clalancette clalancette merged commit fb91c10 into ros2:master May 4, 2021
@christophebedard christophebedard deleted the deprecate-rcutils-get-env-header branch May 4, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

humble PR scheduled for the H-turtle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants