update guard condition by managing multiple items#51
Closed
iuhilnehc-ynos wants to merge 1 commit intoros2:masterfrom
Closed
update guard condition by managing multiple items#51iuhilnehc-ynos wants to merge 1 commit intoros2:masterfrom
iuhilnehc-ynos wants to merge 1 commit intoros2:masterfrom
Conversation
…ables Co-authored-by: William Woodall <william@osrfoundation.org> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Collaborator
|
@asorbini friendly ping, when you got time. |
Collaborator
|
@iuhilnehc-ynos @fujitatomoya I haven't read through that whole thread, but can you summarize why a guard condition should be allowed to be attached to multiple WaitSets? This seems like a big change, and it's inconsistent with other "waitables" in ROS 2 (that can only be attached to one waitset at a time). This is a fundamental contract being broken and the whole implementation of WaitSets and Conditions will require reviewing. I'm a bit tired of addressing this code in the RMW, so apologies for the push back. |
Collaborator
Author
|
not a correct fix, close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to ros2/rclcpp#1611