Add rmw_publisher_wait_for_all_acked support#20
Conversation
asorbini
left a comment
There was a problem hiding this comment.
Hi @Barry-Xu-2018, thank you for your submission!
I added a few comments and suggestions to make sure the code builds with RTI Connext DDS Micro, and a couple of other minor fixes.
Do you know if rmw#295 will be merged for Galactic?
hopefully 🤞 @wjwwood @clalancette @ivanpauno what do you think? i guess we could have this in |
fujitatomoya
left a comment
There was a problem hiding this comment.
looks good to me with @asorbini 's comments
It's on my list to review/run CI for tonight. Make sure it is rebased if you can, I've been having that stall the others. |
asorbini
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the updates @Barry-Xu-2018.
We should run some CI, but I assume that will happen to validate the rest of the changes in the other PRs.
|
@fujitatomoya @Barry-Xu-2018 any updates on whether this feature will make it into Galactic? Paging @clalancette too. |
|
Galactic API/Feature Freeze. |
f39632a to
a254e98
Compare
|
Do rebase. |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
…stake Signed-off-by: Barry Xu <barry.xu@sony.com>
9fdbd74 to
6bed763
Compare
|
Do rebase. |
…os_time() Signed-off-by: Barry Xu <barry.xu@sony.com>
|
@ivanpauno Address your comments. |
Related to ros2/rmw#295