Update branch master to support Rolling only#15
Merged
Conversation
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Collaborator
Author
|
CI jobs to validate the changes:
EDIT: validate uncrustify errors:
|
This was referenced Mar 26, 2021
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
clalancette
approved these changes
Mar 29, 2021
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I just briefly glanced at it, but what I did look at looks good to me. I think this is the right direction to go in, thanks!
wjwwood
approved these changes
Mar 29, 2021
Member
wjwwood
left a comment
There was a problem hiding this comment.
I also only skimmed the code changes, but README lgtm, and the general pattern of changes lgtm.
I'm happy if CI is happy :)
Collaborator
Author
|
Making sure everything is good after merging:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates branch
masterto make it buildable only with the Rolling release.The PR removes all "feature flags" from
static_config.hpp, includingRMW_CONNEXT_RELEASEand any code meant to support earlier releases.This PR must be merged before creating the next Galactic release in order to be able to create a maintenance branch from the updated
master.The code was changed assuming the following "feature configuration":
Note to reviewers: It would be great to review these changes but they are somewhat trivial. I'm creating this PR mainly to keep track of them for future reference.