Take and return new RMW_DURATION_INFINITE correctly#491
Take and return new RMW_DURATION_INFINITE correctly#491clalancette merged 2 commits intoros2:masterfrom
Conversation
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
@asorbini this is probably not worth merging here, right, and should instead go to |
|
@emersonknapp I can confirm I'd like support for this special value to be added to Feel free to open a PR for Keep in mind that @ivanpauno is also working on some changes related to QoS configuration (see rticommunity/rmw_connextdds#7), so you might want to coordinate these additions with him. |
|
My personal view on this is that the work here is done, so we should just go ahead and merge this. I wouldn't spend much additional time here, given that it is on its way out, but "on its way out" is not the same thing as "gone". |
|
Gist: https://gist.githubusercontent.com/emersonknapp/08a0496aa3726c8053285e6def25ab07/raw/1550d9ed37d12a2824dfb876996e6b09bf6844ba/ros2.repos
|
|
^ the |
My changes have only made it into a branch of I think |
|
Oh! You're right it's only on ARM. Never mind then, we can just ignore that build |
|
@ros-pull-request-builder retest this please |
|
@ahcorde @mjcarroll as maintainers do you have any input on this? |
|
@clalancette friendly ping - should we merge this? |
clalancette
left a comment
There was a problem hiding this comment.
Sorry, I just noticed one issue with this PR. After that, I'm happy to approve.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI (which is probably redundant, but I'm being a little more conservative as we approach the Galactic deadline).
|
Depends on ros2/rmw#301
Meets the new API expectations introduced in ros2/rmw#301 - to accept and return
RMW_DURATION_INFINITEfor cross-implementation consistency.