This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Reduce the shutdown_cleanup_period.#473
Merged
clalancette merged 1 commit intomasterfrom Nov 16, 2020
Merged
Conversation
Contributor
Author
|
CI:
|
brawner
approved these changes
Oct 29, 2020
brawner
left a comment
There was a problem hiding this comment.
Excellent, thanks Chris for doing this
This should greatly reduce how long it takes to shutdown a Connext Node. In local testing the time went from 3 seconds to well under a second. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
951dad7 to
568765a
Compare
Contributor
Author
|
Another CI, hopefully a little more successful:
|
Contributor
Author
|
The Windows failures are well-known by now, so almost certainly not the result of this PR. I was sort of hoping the quicker shutdown type would help this, but it was not to be. In any case, I'm going to merge this one as-is, and we'll deal with the failures elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should greatly reduce how long it takes to shutdown a
Connext Node. In local testing the time went from 3 seconds
to well under a second.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix #325; an open question is whether this has any other side-effects. I'm going to run a full CI with this change in place, and Connext as the only RMW vendor, to see what happens.