Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Support for ON_REQUESTED_INCOMPATIBLE_QOS and ON_OFFERED_INCOMPATIBLE_QOS events#398

Merged
ivanpauno merged 2 commits intoros2:masterfrom
aws-ros-dev:miaofei/incompatible_qos
Mar 27, 2020
Merged

Support for ON_REQUESTED_INCOMPATIBLE_QOS and ON_OFFERED_INCOMPATIBLE_QOS events#398
ivanpauno merged 2 commits intoros2:masterfrom
aws-ros-dev:miaofei/incompatible_qos

Conversation

@mm318
Copy link
Copy Markdown
Member

@mm318 mm318 commented Mar 24, 2020

Related to this feature request. The design and implementation details can also be found there.

Handling events of type REQUESTED_INCOMPATIBLE_QOS_STATUS and OFFERED_INCOMPATIBLE_QOS_STATUS

Signed-off-by: Miaofei <miaofei@amazon.com>
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

Signed-off-by: Miaofei <miaofei@amazon.com>
@ivanpauno ivanpauno merged commit c27c246 into ros2:master Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants