This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Closed
clalancette
reviewed
May 1, 2019
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Just the question about error handling in the stubs.
| const rosidl_message_bounds_t * message_bounds, | ||
| rmw_publisher_allocation_t * allocation) | ||
| { | ||
| // Unused in current implementation. |
Contributor
There was a problem hiding this comment.
As with the other rmw implementations, I think we should probably return an error here and below.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
clalancette
approved these changes
May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#159