Add type hash to rmw_topic_endpoint_info_t (rep2011)#348
Merged
clalancette merged 6 commits intoros2:rollingfrom Mar 15, 2023
Merged
Add type hash to rmw_topic_endpoint_info_t (rep2011)#348clalancette merged 6 commits intoros2:rollingfrom
clalancette merged 6 commits intoros2:rollingfrom
Conversation
14 tasks
ec88eaf to
2524e0a
Compare
5e82fe0 to
4795cca
Compare
Contributor
Author
|
@wjwwood @methylDragon @ivanpauno this is ready for review, the types are finalized in the dependency PR, we're only hashing out final details |
clalancette
requested changes
Mar 13, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
One minor thing to fix here, then I think this is good to go.
clalancette
approved these changes
Mar 13, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
|
Now that ros2/rosidl#722 is merged, we can run CI on this one alone and merge it in: CI:
|
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
049a83b to
04f9e43
Compare
Contributor
|
I had to rebase this to get the incompatible type stuff in. I've done that now, here is another CI:
|
Contributor
|
The test failures on Windows are known flakes. So going ahead and merging this one in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1159
Depends on ros2/rosidl#722
Adds
topic_type_hashfield tormw_topic_endpoint_info_tso that it can be filled by RMW implementations.