Skip to content

Add in inconsistent topic defines and data structures.#339

Merged
clalancette merged 2 commits intorollingfrom
clalancette/inconsistent-topic-event
Mar 13, 2023
Merged

Add in inconsistent topic defines and data structures.#339
clalancette merged 2 commits intorollingfrom
clalancette/inconsistent-topic-event

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Part of ros2/ros2#1361

@ivanpauno
Copy link
Copy Markdown
Member

what's the equivalent event in DDS?

@ivanpauno
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have one comment

@clalancette clalancette self-assigned this Jan 5, 2023
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from cea020e to e799e86 Compare January 24, 2023 18:19
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from e799e86 to 617265f Compare February 3, 2023 16:52
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette force-pushed the clalancette/inconsistent-topic-event branch from 17f884f to 8f1d9ef Compare March 10, 2023 14:53
@clalancette clalancette merged commit 949f410 into rolling Mar 13, 2023
@clalancette clalancette deleted the clalancette/inconsistent-topic-event branch March 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants