Add API for taking a sequence of messages#212
Merged
Conversation
This was referenced Apr 10, 2020
Member
Author
|
Covering all branches:
|
iluetkeb
reviewed
Apr 14, 2020
wjwwood
requested changes
Apr 14, 2020
jacobperron
reviewed
Apr 14, 2020
jacobperron
reviewed
Apr 14, 2020
f28532a to
3d7d7a3
Compare
3d7d7a3 to
257ed01
Compare
jacobperron
approved these changes
Apr 16, 2020
Member
jacobperron
left a comment
There was a problem hiding this comment.
Just some minor comments. LGTM
wjwwood
reviewed
Apr 16, 2020
54667ff to
7453971
Compare
Member
Author
|
CI incorporating all changes:
|
wjwwood
approved these changes
Apr 23, 2020
Member
Author
|
Member
Author
|
Linux and macOS are failing with Connext patching issues, similar to here: ros2/rmw_connext#399 (comment) Windows went green too quickly. |
Member
Author
|
Member
Author
|
One more?
|
Karsten1987
approved these changes
Apr 23, 2020
Contributor
Karsten1987
left a comment
There was a problem hiding this comment.
just out of curiosity, does it make sense to have a take_all or similar which takes all available messages at a certain timestamp? Or maybe another rmw method to get the amount of available methods per subscription so that the caller side can allocate the sequence appropriately?
Might be out of scope though.
7453971 to
e553199
Compare
This will allow users to take multiple messages in one take call if they are available in the underlying middleware, verus having to make multiple rmw_take calls in a row. Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org> Co-Authored-By: William Woodall <william+github@osrfoundation.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
e553199 to
40d5457
Compare
Member
Author
|
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to take multiple messages in one take call if they
are available in the underlying middleware, versus having to make
multiple rmw_take calls in a row.
Signed-off-by: Michael Carroll michael@openrobotics.org