add pub/sub option structures to support rmw specific payload feature#187
Merged
add pub/sub option structures to support rmw specific payload feature#187
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
mjcarroll
reviewed
Oct 5, 2019
mjcarroll
approved these changes
Oct 5, 2019
Member
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM with one documentation note.
|
@wjwwood it would be really nice if there were (e.g.) a version macro for the RMW interface so that a single source can be used to cover some of these changes. I suppose |
Member
Author
|
@eboasson that's a good idea, can you open an issue to track that? This isn't the first time we've needed to change API in rmw and it won't be the last, so I think having tools for you to have a "single" source is out of scope for this pr at least. |
Signed-off-by: William Woodall <william@osrfoundation.org>
mjcarroll
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#882