Add new QoS policy data types to rmw#173
Merged
wjwwood merged 3 commits intoros2:masterfrom Apr 16, 2019
Merged
Conversation
This was referenced Apr 12, 2019
emersonknapp
approved these changes
Apr 12, 2019
Member
Author
|
@thomas-moulard - please run the following CI job:
|
|
Member
Author
|
Just realized that I needed to rebase since ros2/rclcpp#673 was merged. |
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Member
Author
|
Hi @wjwwood, this PR is ready for review. It and its associated PRs make no functional changes. |
Member
Author
|
Re-running CI now that the PR is rebased.
|
wjwwood
approved these changes
Apr 16, 2019
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, though the one sentence per line thing should be fixed before merging.
Signed-off-by: Miaofei <miaofei@amazon.com>
wjwwood
approved these changes
Apr 16, 2019
Member
Author
|
Should be ready to be merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more fields to the
rmw_qos_profile_tstruct to specify liveliness, deadline, and lifespan QoS policies.Also, adds new structs for conveying liveliness and deadline QoS statuses.
These changes are required for implementing the upcoming QoS features.