Skip to content

make log location parameter const#97

Merged
wjwwood merged 1 commit intomasterfrom
const_log_location
Mar 16, 2018
Merged

make log location parameter const#97
wjwwood merged 1 commit intomasterfrom
const_log_location

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Mar 15, 2018

It doesn't appear to need to be mutable, and it can be copied by the output handler if needed.

@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Mar 15, 2018
@wjwwood wjwwood self-assigned this Mar 15, 2018
@wjwwood wjwwood mentioned this pull request Mar 15, 2018
Merged
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 15, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

mikaelarguedas
mikaelarguedas approved these changes Mar 15, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, similarly severity doesn't seem to need to be mutable either (in the few functions I looked at).

Edit: severity is an int not a pointer to int ... so it doesn't make a difference >_<

@wjwwood wjwwood merged commit 8780784 into master Mar 16, 2018
@wjwwood wjwwood deleted the const_log_location branch March 16, 2018 00:08
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@wjwwood wjwwood

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wjwwood @mikaelarguedas