Logging autoinit fixup; add RCUTILS_WARN_UNUSED to logging functions#81
Merged
Logging autoinit fixup; add RCUTILS_WARN_UNUSED to logging functions#81
Conversation
It's only an issue for one of these, it's defensive for the others
wjwwood
approved these changes
Dec 2, 2017
mikaelarguedas
approved these changes
Dec 2, 2017
Member
mikaelarguedas
left a comment
There was a problem hiding this comment.
so I'm confident that even without it CI would have come back green for just this PR
👍 feel free to merge without rerunning CI on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent commits here, please see the individual messages.
The buildfarm is a bit congested at the moment so these CI jobs are from yesterday that included changes from this PR and an additional commit that I have since spun off into a separate PR (#80). That additional commit was unrelated to these changes so I'm confident that even without it CI would have come back green for just this PR.