Merged
Conversation
dirk-thomas
approved these changes
Nov 16, 2017
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
Sounds good to me now that we have the environment variable to customize it. Is this env var already mentioned in the wiki somewhere? If not, it might be good to add.
mikaelarguedas
approved these changes
Nov 16, 2017
Member
mikaelarguedas
left a comment
There was a problem hiding this comment.
Glad we can finally make these less verbose.
👍 For documenting it on the wiki
Member
Author
|
This adds it to the doxygen docs but no wiki page just yet, but it is planned further down the line for ros2/ros2#425 |
Member
Author
|
ok I probably should have waited for CI to finish there 😨 but I'll followup if CI tests end up failing on other platforms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just severity, name and message.
The reasoning is that most of the time our demo output is too verbose. If someone is debugging something specific, they can see the caller location information by setting the
RCUTILS_CONSOLE_OUTPUT_FORMATenvironment variable to e.g."[{severity}] [{name}]: {message} ({function_name}() at {file_name}:{line_number})"(it can't currently be changed at runtime).