Add macros for min severity to not compile out#60
Merged
Conversation
This was broken because it was referencing enum values
dhood
commented
Oct 25, 2017
resource/logging_macros.h.em
Outdated
| /** | ||
| * \def RCUTILS_LOG_MIN_SEVERITY | ||
| * Define RCUTILS_LOG_MIN_SEVERITY=RCUTILS_LOG_SEVERITY_[DEBUG|INFO|WARN|ERROR|FATAL] | ||
| * Define RCUTILS_LOG_MIN_SEVERITY=RCUTILS_LOG_MIN_SEVERITY_[DEBUG|INFO|WARN|ERROR|FATAL|NONE] |
Member
Author
There was a problem hiding this comment.
self-review: I'll move NONE to a difference sentence.
wjwwood
approved these changes
Oct 25, 2017
Member
Author
|
Will wait for this CI before merging but this functionality doesn't have tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken because it was referencing enum values (@wjwwood this is why I couldn't get it to work).
Alternatively we could choose to factor out definitions for the values used in the severity enum, but for the purpose of deciding whether or not to compile-in macros the value is not important, just the ordering.