[Foxy backport]: Disable a Windows platform warning. (#311)#319
Merged
clalancette merged 1 commit intofoxyfrom Dec 3, 2020
Merged
[Foxy backport]: Disable a Windows platform warning. (#311)#319clalancette merged 1 commit intofoxyfrom
clalancette merged 1 commit intofoxyfrom
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
jacobperron
approved these changes
Dec 3, 2020
Contributor
Author
|
The Windows jobs are still yellow, but that's because of the (unrelated) CMake warnings. We'd also have to backport some additional stuff for that. The MSBuild warnings that this PR targets are gone. So I'm going to go ahead and merge this one to Foxy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This closes #310 .