Skip to content

Move likely/unlikely macros from logging.h to macros.h#253

Merged
ivanpauno merged 1 commit intomasterfrom
ivanpauno/move-likely-unlikely-attributes-to-macros-header
May 22, 2020
Merged

Move likely/unlikely macros from logging.h to macros.h#253
ivanpauno merged 1 commit intomasterfrom
ivanpauno/move-likely-unlikely-attributes-to-macros-header

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno commented May 21, 2020

☝️ what the title says

@ivanpauno
Move likely/unlikely macros from logging.h to macros.h
b53a24f 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added enhancement New feature or request in review Waiting for review (Kanban column) labels May 21, 2020
@ivanpauno ivanpauno requested review from hidmic and jacobperron May 21, 2020 19:14
@ivanpauno ivanpauno self-assigned this May 21, 2020
@jacobperron
Copy link
Copy Markdown
Member

jacobperron commented May 21, 2020 •
edited
Loading

Is this change necessary for something or just cleanup? I think it would be better to wait to land this for G-turtle since it's changing public API.

Nevermind, I see we're including the header in the old place.

@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented May 21, 2020

Job config:

  • build: --packages-up-to rcutils
  • test: --packages-select rcutils

CI jobs:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno mentioned this pull request May 21, 2020
Merged
fujitatomoya
fujitatomoya approved these changes May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanpauno ivanpauno merged commit 0b0fa4b into master May 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/move-likely-unlikely-attributes-to-macros-header branch May 22, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

@hidmic hidmic hidmic approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ivanpauno ivanpauno

Labels

enhancement New feature or request in review Waiting for review (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivanpauno @jacobperron @hidmic @fujitatomoya