increase max length of env var value on Windows to 32767#201
Merged
dirk-thomas merged 1 commit intomasterfrom Jan 22, 2020
Merged
increase max length of env var value on Windows to 32767#201dirk-thomas merged 1 commit intomasterfrom
dirk-thomas merged 1 commit intomasterfrom
Conversation
Member
|
Looks to have been impacted by a network issue, rerunning:
|
Member
Author
I got rid of the non-Windows builds since the patch only affects Windows. |
Member
Author
|
While the Windows build has a very high test failure count (75) that seems to match the latest nightly Windows Debug build: https://ci.ros2.org/view/nightly/job/nightly_win_deb/1504/ |
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
e0280ba to
b7d6d36
Compare
mjcarroll
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use
rcutils_get_env()in ros2/rmw_implementation#57 fails since that package e.g. tries to get the environment variablePATHwhich exceeds the current limit of 2048 characters on the Jenkins CI nodes.Therefore this PR raises the limit to the maximum size of the sum of all environment variables (see https://devblogs.microsoft.com/oldnewthing/20100203-00/?p=15083).