Conversation
dirk-thomas
approved these changes
Sep 12, 2018
wjwwood
approved these changes
Sep 12, 2018
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC will warn with code C4307 and calculate an unintended value if the result of
RCUTILS_S_TO_NSis greater than 32bits. As far as I can tell this is because1000is small enough to fit in anintso that becomes its type according to https://en.cppreference.com/w/cpp/language/integer_literal . MSVC says the size ofintis 4 bytes even on 64bit platforms https://msdn.microsoft.com/en-us/library/s3f49ktz.aspx. In theRCUTILS_S_TO_NScase this means thatseconds * 1000 * 1000 * 1000is done using 32bit math and will overflow when seconds is greater than 2.