Skip to content

Fix thread_safety_annotation filename to .hpp#6

Merged
emersonknapp merged 1 commit intoros2:masterfrom
emersonknapp:hpp-name
Mar 28, 2019
Merged

Fix thread_safety_annotation filename to .hpp#6
emersonknapp merged 1 commit intoros2:masterfrom
emersonknapp:hpp-name

Conversation

@emersonknapp
Copy link
Copy Markdown
Contributor

@emersonknapp emersonknapp commented Mar 28, 2019

Signed-off-by: Emerson Knapp eknapp@amazon.com

Copy link
Copy Markdown

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test must be updated too.

@thomas-moulard
Copy link
Copy Markdown

@emersonknapp Can you attach a Gist to this PR so that I can run CI?

@emersonknapp
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm - indeed it is!

@thomas-moulard
Copy link
Copy Markdown

thomas-moulard commented Mar 28, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI is green.

@thomas-moulard
Copy link
Copy Markdown

@emersonknapp this is green - please add a DCO to this one and merge 🚢

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants