find_library: Centralize functionality here#25
Merged
dirk-thomas merged 8 commits intomasterfrom Sep 11, 2019
Merged
Conversation
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Member
Author
|
Two PRs using this new location: |
emersonknapp
approved these changes
Sep 6, 2019
Contributor
emersonknapp
left a comment
There was a problem hiding this comment.
Looks good, thanks for updating the previous one
Contributor
|
Do we need another reviewer to move this forward? |
Member
Author
Not anymore. I just changed the approval limit from 2 to 1 (since this was the only repo requiring two reviews and the people which set this up seem to not watch it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #4.