Use std::shared_ptr holder type for Destroyable subsclasses to keep grandparent wrapper instances alive#758
Closed
Use std::shared_ptr holder type for Destroyable subsclasses to keep grandparent wrapper instances alive#758
std::shared_ptr holder type for Destroyable subsclasses to keep grandparent wrapper instances alive#758Conversation
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
std::shared_ptr holder type for Destroyable subsclasses to keep grandparent wrapper instances alive
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665 - alternative to #757
This makes
Destroyablesubclasses use thestd::shared_ptrholder type and useshared_from this. This allows classes to keep the parent wrapper instance alive so that grandparent's are kept alive too.Since
clockhas no grandparent types, there isn't actually an issue inmaster- it's not until #756 adds Publisher and Subscription that it becomes an issue.. Maybe it's fine to leave this as is, and include this fix via #757 to #756?