Skip to content

Use py::class_ for rcl_event_t#750

Merged
sloretz merged 3 commits intomasterfrom
pybind11_rcl_event_t
Apr 2, 2021
Merged

Use py::class_ for rcl_event_t#750
sloretz merged 3 commits intomasterfrom
pybind11_rcl_event_t

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Apr 1, 2021

Part of #665

This uses a py::class_ definition for rcl_event_t

@sloretz sloretz self-assigned this Apr 1, 2021
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 1, 2021

Windows Debug CI (build: --packages-up-to rclpy test: --packages-select rclpy) Build Status

@sloretz sloretz mentioned this pull request Apr 1, 2021
34 tasks
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 2, 2021

build: --packages-up-to rclpy test: --packages-select rclpy

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz force-pushed the pybind11_rcl_event_t branch from 906fe61 to f213a96 Compare April 2, 2021 17:30
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 2, 2021

Rebased without making any changes

CI (build: --packages-above-and-dependencies rclpy test: --packages-above rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

sloretz added 3 commits April 2, 2021 14:03
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz force-pushed the pybind11_rcl_event_t branch from f213a96 to 8501bcb Compare April 2, 2021 21:04
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 2, 2021

Rebased without changes

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 2, 2021

Approved and CI LGTM, merging!

@sloretz sloretz merged commit 95fc749 into master Apr 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the pybind11_rcl_event_t branch April 2, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants