Use py::class_ for rmw_service_info_t and rmw_request_id_t#748
Merged
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
commented
Mar 31, 2021
| if (!header) { | ||
| throw std::bad_alloc(); | ||
| } | ||
| rmw_service_info_t header; |
Contributor
Author
There was a problem hiding this comment.
I opted for using a variable on the stack since this is a fairly small struct. Let me know if heap allocation would be preferred.
Contributor
Author
|
CI (build:
|
34 tasks
Contributor
Author
|
There were CI failures that I believe were fixed in other repos.
|
sloretz
approved these changes
Apr 2, 2021
Contributor
Author
|
The macOS build failure and the windows warning are unrelated. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665
This refactors the code using
rmw_service_info_tandrmw_request_id_tto use a py::class_ definition.