Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
CI (build:
|
sloretz
left a comment
There was a problem hiding this comment.
Looking good with a few more comments addressed!
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
CI (build:
|
rclpy/src/rclpy/service.cpp
Outdated
| taken_request.release(); | ||
|
|
||
| return std::move(result_list); | ||
| return result_list; |
There was a problem hiding this comment.
Looks like there's a new clang warning here.
https://ci.ros2.org/job/ci_osx/11897/clang-tidy/new/source.dce8798b-3637-471a-8bb9-b4b3454f5026/#156
I think it can be fixed by returning result_tuple instead of result_list (to match the py::tuple return type)
Signed-off-by: ahcorde <ahcorde@gmail.com>
sloretz
left a comment
There was a problem hiding this comment.
LGTM with a rebase and green CI
|
CI (build:
|
azeey
left a comment
There was a problem hiding this comment.
LGTM! Just a couple of minor comments.
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
The Windows failure is unrelated. Merging! |
Related to #665
This converts the Service functions to a C++ class.
Signed-off-by: ahcorde ahcorde@gmail.com