Skip to content

Use py::class_ for rcl_duration_t#744

Merged
ahcorde merged 3 commits intomasterfrom
ahcorde/rclpy/duration
Mar 31, 2021
Merged

Use py::class_ for rcl_duration_t#744
ahcorde merged 3 commits intomasterfrom
ahcorde/rclpy/duration

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 31, 2021

Part of #665

This is a PR that refactors the code using rcl_duration_t to use a py::class_ definition.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Mar 31, 2021
@ahcorde ahcorde mentioned this pull request Mar 31, 2021
34 tasks
Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 31, 2021

build up-to rclpy and testing rclpy

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 31, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 4c74e60 into master Mar 31, 2021
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 31, 2021

The warning on Windows is unrelated.

@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rclpy/duration branch March 31, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants