Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
CI (build:
|
34 tasks
Contributor
Author
|
And one more CI just to rclpy to see if the warnings above are all unrelated and downstream (build:
|
hidmic
approved these changes
Mar 31, 2021
Contributor
Author
|
CI LGTM, windows warning is in cyclonedds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665
This is a step towards getting rid of the C code in
rclpy_common. There was trouble on Windows debug before when trying to put code that used pybind11 intorclpy_commonthat led to removing it in #727. We don't need to figure that out if all the code is in the same shared library, so this PR moves all the pybind11 code into a single shared library.This has an added benefit of reducing the code size from 4.8 MB to 2.8 MB.