Converting last of _rclpy.c to pybind11#738
Merged
gbalke merged 14 commits intoros2:masterfrom Mar 30, 2021
Merged
Conversation
added 3 commits
March 25, 2021 11:43
Signed-off-by: Greg Balke <greg@openrobotics.org>
Signed-off-by: Greg Balke <greg@openrobotics.org>
Signed-off-by: Greg Balke <greg@openrobotics.org>
Contributor
Author
34 tasks
ahcorde
requested changes
Mar 26, 2021
hidmic
reviewed
Mar 26, 2021
sloretz
reviewed
Mar 29, 2021
Signed-off-by: Greg Balke <greg@openrobotics.org>
52df391 to
d413c1f
Compare
added 3 commits
March 29, 2021 12:14
Signed-off-by: Greg Balke <greg@openrobotics.org>
Signed-off-by: Greg Balke <greg@openrobotics.org>
Signed-off-by: Greg Balke <greg@openrobotics.org>
Contributor
Author
added 3 commits
March 29, 2021 13:50
Signed-off-by: Greg Balke <greg@openrobotics.org>
Signed-off-by: Greg Balke <greg@openrobotics.org>
Signed-off-by: Greg Balke <greg@openrobotics.org>
Contributor
Author
|
@sloretz I merged and cleaned out I attempted to just delete the file and remove it from |
Contributor
Author
Contributor
In addition to deleting the file and removing it from the --- <unnamed>
+++ <unnamed>
@@ -2,26 +2,9 @@
from rpyutils import import_c_library
package = 'rclpy'
-rclpy_implementation = import_c_library('._rclpy', package)
+rclpy_implementation = import_c_library('._rclpy_pybind11', package)
rclpy_action_implementation = import_c_library('._rclpy_action', package)
rclpy_logging_implementation = import_c_library('._rclpy_logging', package)
rclpy_signal_handler_implementation = import_c_library('._rclpy_signal_handler', package)
rclpy_handle_implementation = import_c_library('._rclpy_handle', package)
rclpy_pycapsule_implementation = import_c_library('._rclpy_pycapsule', package)
-
-
-# Temporary code for converting giant _rclpy module to pybind11
-def _combine_split_modules():
- global rclpy_implementation
- module = import_c_library('._rclpy_pybind11', package)
- for attr in dir(module):
- thing = getattr(module, attr)
- if attr.startswith('rclpy_'):
- # It's a wrapped C function
- setattr(rclpy_implementation, attr, thing)
- elif isinstance(thing, type):
- # It's a custom type
- setattr(rclpy_implementation, attr, thing)
- elif '_' != attr[0] and attr.upper() == attr:
- # It's a module constant
- setattr(rclpy_implementation, attr, thing) |
Contributor
|
and deleting these two as well |
hidmic
reviewed
Mar 29, 2021
Signed-off-by: Greg Balke <greg@openrobotics.org>
Signed-off-by: Greg Balke <greg@openrobotics.org>
Contributor
Author
hidmic
approved these changes
Mar 29, 2021
Contributor
|
Pending green CI ! |
gbalke
commented
Mar 29, 2021
Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: Greg Balke <greg@openrobotics.org>
4e06d0a to
515b284
Compare
368a095 to
1c0d1c4
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665 covering: