Skip to content

Use py::class_ for rcl_time_point_t#737

Merged
sloretz merged 2 commits intomasterfrom
pybind11_class_time_point
Mar 29, 2021
Merged

Use py::class_ for rcl_time_point_t#737
sloretz merged 2 commits intomasterfrom
pybind11_class_time_point

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Mar 24, 2021

Part of #665

This is a PR that refactors the code using rcl_time_point_t to use a py::class_ definition. This is an example of what moving away from PyCapsules looks like for C structs that aren't being wrapped with rclpy_handle_t currently.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Mar 24, 2021
@sloretz sloretz mentioned this pull request Mar 24, 2021
34 tasks
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 29, 2021

CI (build: --packages-above-and-dependencies rclpy test: --packages-above rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 29, 2021

CMake warning is in cyclonedds, not this PR. Merging 🎉

@sloretz sloretz merged commit 4276ba3 into master Mar 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the pybind11_class_time_point branch March 29, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants