Conversation
34 tasks
gbalke
approved these changes
Mar 24, 2021
| static_cast<rmw_qos_profile_t *>( | ||
| PyMem_Malloc(sizeof(rmw_qos_profile_t))), PyMem_Free); | ||
| if (!qos_profile) { | ||
| throw std::bad_alloc(); |
Contributor
There was a problem hiding this comment.
I believe this isn't documented in the header.
|
|
||
| // Fill a given rmw_time_t from an rclpy.duration.Duration instance. | ||
| void | ||
| _convert_py_duration_to_rmw_time(py::capsule pyduration, rmw_time_t * out_time) |
Contributor
There was a problem hiding this comment.
This not being a bool definitely made the code below a lot simpler!
sloretz
approved these changes
Mar 25, 2021
Contributor
sloretz
left a comment
There was a problem hiding this comment.
Just a suggestion to check the pycapsule names.
Contributor
Author
|
CI up to
|
sloretz
approved these changes
Mar 25, 2021
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
e0d3644 to
1b922a5
Compare
Contributor
Author
|
CI up to
|
Contributor
Author
|
Alright, going in ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665. It's a shallow port (i.e. didn't migrate relevant
common.cfunctions) in hopes we can eventually bind the entireqos.pymodule.CI up to
rclpy: