Skip to content

Pybind 11: count_subscribers and count_publishers#732

Merged
ahcorde merged 6 commits intomasterfrom
ahcorde/py11/count_pubsub
Mar 24, 2021
Merged

Pybind 11: count_subscribers and count_publishers#732
ahcorde merged 6 commits intomasterfrom
ahcorde/py11/count_pubsub

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 23, 2021

Part of #665

Handles:

rclpy_count_subscribers
rclpy_count_publishers

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde ahcorde requested a review from hidmic March 23, 2021 19:49
@ahcorde ahcorde self-assigned this Mar 23, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the ahcorde/py11/count_pubsub branch from 6a3602b to 7ea8d0e Compare March 23, 2021 19:50
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 23, 2021

Building up-to rclpy and testing rclpy:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Mar 23, 2021
34 tasks
@sloretz sloretz self-requested a review March 23, 2021 20:23
@hidmic
Copy link
Copy Markdown
Contributor

hidmic commented Mar 23, 2021

@ahcorde uncrustify doesn't seem to be happy.

ahcorde added 2 commits March 23, 2021 21:37
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 24, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde requested a review from hidmic March 24, 2021 07:04
Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 24, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 24, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 8a712bd into master Mar 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/py11/count_pubsub branch March 24, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants