Skip to content

Include pybind11 first to fix windows debug warning#731

Merged
sloretz merged 1 commit intomasterfrom
pybind11_qos_pydebug
Mar 23, 2021
Merged

Include pybind11 first to fix windows debug warning#731
sloretz merged 1 commit intomasterfrom
pybind11_qos_pydebug

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Mar 22, 2021

I think this will fix the warning on Windows Debug https://ci.ros2.org/job/ci_windows/14100/

Part of #665

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested a review from hidmic March 22, 2021 21:09
@sloretz sloretz self-assigned this Mar 22, 2021
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 22, 2021

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows Debug Build Status

Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, my bad. Thanks for the fix @sloretz.

@sloretz sloretz merged commit dc22fe9 into master Mar 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the pybind11_qos_pydebug branch March 23, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants