Conversation
0f3f8d5 to
6935e66
Compare
gbalke
approved these changes
Mar 19, 2021
rclpy/src/rclpy/qos_events.cpp
Outdated
| } | ||
| if (RCL_RET_UNSUPPORTED == ret) { | ||
| rcl_reset_error(); | ||
| throw std::runtime_error("take event is not implemented"); |
Contributor
There was a problem hiding this comment.
I believe this isn't documented in take_event's header.
Contributor
Author
There was a problem hiding this comment.
Indeed. This is nonsense though. There's no documentation of rcl_take_event() returning RCL_RET_UNSUPPORTED. There's no implementation that does that either. See 6ba21f2 for a fix.
sloretz
reviewed
Mar 19, 2021
Contributor
sloretz
left a comment
There was a problem hiding this comment.
Just a couple nice-to-have's
rclpy/src/rclpy/qos_events.cpp
Outdated
| py::capsule | ||
| event_wrap_in_capsule(unique_cstruct_ptr<rcl_event_t> event, py::capsule pyparent) | ||
| { | ||
| rclpy_handle_t * event_handle = _rclpy_create_handle( |
Contributor
There was a problem hiding this comment.
Mind using this pattern with rclpy_create_handle_capsule instead of _rclpy_create_handle? I think it's a little easier to follow.
rclpy/rclpy/src/rclpy/subscription.cpp
Lines 106 to 122 in 41f9c2f
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
6ba21f2 to
2795b16
Compare
Contributor
Author
|
Rebased to solve merge conflicts. PTAL ! |
Contributor
Author
|
CI up to
|
sloretz
approved these changes
Mar 22, 2021
Contributor
Author
|
Going in! |
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Part of #665.
CI up to
rclpy: