Conversation
Contributor
Author
|
CI (build:
|
cottsay
reviewed
Mar 10, 2021
Comment on lines
-524
to
+514
| with _WaitSet() as wait_set, ExitStack() as context_stack: | ||
| wait_set = _rclpy.rclpy_get_zero_initialized_wait_set() | ||
| with ExitStack() as context_stack: |
Member
There was a problem hiding this comment.
Now that the GC can destroy the wait set when it pleases, are there any dependencies between the wait set and the entities that we need to handle?
Contributor
Author
There was a problem hiding this comment.
None that needs to be handled by the wait set. context_stack makes sure the entities in the wait set stay alive until rcl_wait() finishes. After that it's totally fine to fini the wait set even if entities no longer exist because it doesn't do anything with those pointers.
Replaces rclpy_destroy_wait_set with pycapsule destructor for the rcl_wait_set_t type. Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
9b42b68 to
e899159
Compare
Contributor
Author
|
CI (build:
|
azeey
reviewed
Mar 10, 2021
34 tasks
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
CI (build:
|
azeey
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665
This also replaces
rclpy_destroy_wait_setandrclpy.executors._WaitSetwith a pycapsule destructor.