Skip to content

Convert rclpy service functions to pybind11#703

Merged
cottsay merged 6 commits intomasterfrom
cottsay/pybind11_service
Mar 10, 2021
Merged

Convert rclpy service functions to pybind11#703
cottsay merged 6 commits intomasterfrom
cottsay/pybind11_service

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Mar 9, 2021

Part of #665

Converts:

  • rclpy_create_service
  • rclpy_send_response
  • rclpy_take_response

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added the enhancement New feature or request label Mar 9, 2021
@cottsay cottsay requested a review from sloretz March 9, 2021 07:12
@cottsay cottsay self-assigned this Mar 9, 2021
cottsay added 3 commits March 8, 2021 23:15
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Mar 9, 2021

@ros-pull-request-builder retest this please

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay removed the enhancement New feature or request label Mar 9, 2021
@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Mar 9, 2021

@ros-pull-request-builder retest this please

I think the flaky tests are getting worse.

@cottsay cottsay mentioned this pull request Mar 9, 2021
34 tasks
@cottsay cottsay merged commit 2ed2746 into master Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/pybind11_service branch March 10, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants