Convert rclpy client functions to pybind11#701
Merged
Conversation
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Member
Author
|
@ros-pull-request-builder retest this please |
Signed-off-by: Scott K Logan <logans@cottsay.net>
Member
Author
|
@ros-pull-request-builder retest this please |
sloretz
reviewed
Mar 9, 2021
rclpy/src/rclpy/client.cpp
Outdated
| return pycli; | ||
| } | ||
|
|
||
| uint64_t |
Contributor
There was a problem hiding this comment.
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
fbe37cd to
0a4f62d
Compare
Member
Author
|
@ros-pull-request-builder retest this please |
sloretz
reviewed
Mar 9, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
sloretz
approved these changes
Mar 9, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
azeey
approved these changes
Mar 9, 2021
| { | ||
| auto cli = static_cast<rclpy_client_t *>(p); | ||
| if (!cli) { | ||
| // Warning should use line number of the current stack frame |
Contributor
There was a problem hiding this comment.
There was a PyErr_Clear() in the _rclpy.c code. I assume it was removed on purpose?
Member
Author
There was a problem hiding this comment.
It doesn't really make sense to me why that was there in the first place. None of the other _rclpy_destroy_* functions have it.
34 tasks
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665
Converts:
CI (build: --packages-up-to rclpy test: --packages-select rclpy)