Convert clock and time functions to pybind11#699
Merged
Conversation
34 tasks
cottsay
approved these changes
Mar 8, 2021
Member
cottsay
left a comment
There was a problem hiding this comment.
Some comments, but no blockers. Looks good!
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Co-authored-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Contributor
Author
|
CI (build:
|
Contributor
Author
|
|
Contributor
Author
|
@ros-pull-request-builder retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665
Converts time_point and clock functions to pybind11. Along the way I fixed a signed/unsigned bug where python to C conversion allowed time values up to 2**64-1 to be set to be set, but the
rcl_time_point_tstruct only accepts up to 2**63-1 because the type is signed. I also replaced theClockTypeandClockChangeenums with pybind11 ones to make the conversion between the C and python layer easier.