Replace rmw_connext_cpp with rmw_connextdds#698
Merged
clalancette merged 1 commit intoros2:masterfrom Mar 25, 2021
asorbini:asorbini/rmw_connextdds
Merged
Replace rmw_connext_cpp with rmw_connextdds#698clalancette merged 1 commit intoros2:masterfrom asorbini:asorbini/rmw_connextdds
clalancette merged 1 commit intoros2:masterfrom
asorbini:asorbini/rmw_connextdds
Conversation
clalancette
approved these changes
Mar 6, 2021
ivanpauno
reviewed
Mar 8, 2021
Member
ivanpauno
left a comment
There was a problem hiding this comment.
IMO, we don't need to remove support for rmw_connext_cpp right now.
This PR doesn't seem to have any change needed to make rmw_connextdds pass CI, so I wouldn't merge it now.
Member
|
Anyways, we're not going to run |
Contributor
|
I'm good with this change, but we actually have to wait to merge it until we completely remove |
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
ivanpauno
approved these changes
Mar 24, 2021
Member
☝️ |
Contributor
|
Green CI is at ros2/rmw_connextdds#9 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all references to
rmw_connext_cpp, so that it may be replaced byrmw_connextdds.The PR re-enables two tests which were previously disabled for Connext.
See rticommunity/rmw_connextdds #9 for a list of related PRs, and an overview of all the changes required to replace ros2/rmw_connext (
rmw_connext_cpp) with rticommunity/rmw_connextdds in the ROS2 source tree.