Convert subscription functions to pybind11#696
Merged
Conversation
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
commented
Mar 5, 2021
cottsay
commented
Mar 5, 2021
cottsay
commented
Mar 5, 2021
34 tasks
Signed-off-by: Scott K Logan <logans@cottsay.net>
c8e894e to
ffcb08d
Compare
sloretz
reviewed
Mar 5, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
sloretz
reviewed
Mar 9, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
This reverts commit d838d24. Signed-off-by: Scott K Logan <logans@cottsay.net>
6cf7be8 to
e00c660
Compare
Member
Author
|
@ros-pull-request-builder retest this please |
sloretz
approved these changes
Mar 9, 2021
azeey
reviewed
Mar 9, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
Member
Author
|
@ros-pull-request-builder retest this please |
azeey
approved these changes
Mar 9, 2021
Member
Author
|
Test failures are cppcheck timeouts. I'll look into bumping the timeout. For now, this change is good to go in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665
Converts:
CI (build: --packages-up-to rclpy test: --packages-select rclpy)