Skip to content

Convert publisher functions to pybind11#695

Merged
cottsay merged 9 commits intomasterfrom
cottsay/pybind11_publisher
Mar 9, 2021
Merged

Convert publisher functions to pybind11#695
cottsay merged 9 commits intomasterfrom
cottsay/pybind11_publisher

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Mar 4, 2021

Part of #665

Converts:

  • rclpy_create_publisher
  • rclpy_publisher_get_subscription_count
  • rclpy_publisher_get_topic_name
  • rclpy_publish
  • rclpy_publish_raw

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested a review from sloretz March 4, 2021 21:12
@cottsay cottsay self-assigned this Mar 4, 2021
@cottsay cottsay mentioned this pull request Mar 4, 2021
34 tasks
@cottsay cottsay removed the request for review from sloretz March 4, 2021 21:41
@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Mar 4, 2021

I completely missed rclpy_create_publisher. Hold off on reviewing this until I get that done.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested a review from sloretz March 5, 2021 01:23
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the cottsay/pybind11_publisher branch from f28029c to 658b6f5 Compare March 9, 2021 00:04
@cottsay cottsay requested a review from sloretz March 9, 2021 00:05
cottsay added 2 commits March 8, 2021 16:33
Signed-off-by: Scott K Logan <logans@cottsay.net>
This reverts commit c37603a.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the cottsay/pybind11_publisher branch from 53b296d to fef231b Compare March 9, 2021 01:32
@cottsay cottsay merged commit d10075e into master Mar 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/pybind11_publisher branch March 9, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants